Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(designer): Introduce collapse node route #6534

Merged
merged 35 commits into from
Feb 13, 2025

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Feb 3, 2025

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

There is no current behavior for this. However, customers with lots of actions will need to scroll across the canvas to find actions.

New Behavior

New behavior will allow users to collapse actions, making the flow smaller in the canvas, therefore users will be able to see more of the flow at once. This also improves performance by not rendering the actions that are collapsed

Impact of Change

  • This is a breaking change.

Test Plan

All new react components have unit test.
Added e2e tests

Screenshots or Videos (if applicable)

Scenario with scope actions

CleanShot.2025-02-05.at.12.36.14.mp4

Scenario with 200 actions

CleanShot.2025-02-05.at.12.39.11.mp4

Update: When clicked in collapsed, now the collapsed node is focused

CleanShot.2025-02-12.at.17.07.47.mp4

@ccastrotrejo ccastrotrejo changed the title Ccastrotrejo/collapsed nodes feat(designe): Introduce collapse node route Feb 3, 2025
@ccastrotrejo ccastrotrejo changed the title feat(designe): Introduce collapse node route feat(designer): Introduce collapse node route Feb 3, 2025
@ccastrotrejo ccastrotrejo marked this pull request as ready for review February 4, 2025 01:15
@ccastrotrejo ccastrotrejo marked this pull request as draft February 4, 2025 01:22
@ccastrotrejo ccastrotrejo marked this pull request as ready for review February 5, 2025 20:45
@hartra344
Copy link
Contributor

Can we also fix it so that when an action is collapsed, we center the graph onto that action rather than having it move around unpredictibly?

@ccastrotrejo
Copy link
Contributor Author

Can we also fix it so that when an action is collapsed, we center the graph onto that action rather than having it move around unpredictibly?

Yep I can do that

@ccastrotrejo ccastrotrejo merged commit 2dee3a3 into main Feb 13, 2025
25 of 28 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/collapsedNodes branch February 13, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants