-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(designer): Introduce collapse node route #6534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
Can we also fix it so that when an action is collapsed, we center the graph onto that action rather than having it move around unpredictibly? |
Yep I can do that |
…trotrejo/collapsedNodes
…trotrejo/collapsedNodes
hartra344
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Current Behavior
There is no current behavior for this. However, customers with lots of actions will need to scroll across the canvas to find actions.
New Behavior
New behavior will allow users to collapse actions, making the flow smaller in the canvas, therefore users will be able to see more of the flow at once. This also improves performance by not rendering the actions that are collapsed
Impact of Change
Test Plan
All new react components have unit test.
Added e2e tests
Screenshots or Videos (if applicable)
Scenario with scope actions
CleanShot.2025-02-05.at.12.36.14.mp4
Scenario with 200 actions
CleanShot.2025-02-05.at.12.39.11.mp4
Update: When clicked in collapsed, now the collapsed node is focused
CleanShot.2025-02-12.at.17.07.47.mp4