Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): Correct toPascalCase regex #6525

Open
wants to merge 1 commit into
base: developer/UnitTestCodeful
Choose a base branch
from
Open

fix(vscode): Correct toPascalCase regex #6525

wants to merge 1 commit into from

Conversation

andrew-eldridge
Copy link

@andrew-eldridge andrew-eldridge commented Jan 31, 2025 •
edited
Loading

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

Current regex fails on test string "_example_string" with leading underscores

New Behavior

New regex accounts for leading underscores

Impact of Change

  • This is a breaking change.

Test Plan

Addressed in existing unit tests

Screenshots or Videos (if applicable)

N/A

hartra344
hartra344 requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@hartra344 hartra344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mention that it's addressed in existing unit tests? In that case, what is prompting the fix? If the test was succeeding before and still succeeding now, but we fixed a real issue then it sounds like we need another unit test. Can you please add that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartra344 hartra344 hartra344 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-eldridge @hartra344