fix(vscode): Remove cwd from workspace path #6508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mireedmsft
approved these changes
Jan 29, 2025
...ode-designer/src/app/commands/createNewProject/createProjectSteps/ScriptProjectCreateStep.ts
Show resolved
Hide resolved
hartra344
approved these changes
Jan 30, 2025
takyyon
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Current Behavior
Since we opted in for the default workspace behavior approach, the extra directory in the "CWD" property when trying to run and debug the logic app was causing issues and the logic app wasn't able to run in vscode
New Behavior
The run and debug task is now able to handle the workspace behavior and now the logic apps can be run
Impact of Change
This is not a breaking change
Test Plan
We figure out this issue was happening from the development team, this issue didn't make it to production. However this issue would have been a blocker to release since as for now this is tested by manual vendor testing.
For future references, I will see if I can test this in unit tests, in the meantime I am still takin a look on how to implement e2e tests for the extension
Screenshots or Videos (if applicable)