-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Improved Unit Test Generation UI & C# Class Structure #6506
Open
samikay101
wants to merge
9
commits into
Azure:developer/UnitTestCodeful
Choose a base branch
from
samikay101:testClassFolderUpdates
base: developer/UnitTestCodeful
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(vscode): Improved Unit Test Generation UI & C# Class Structure #6506
samikay101
wants to merge
9
commits into
Azure:developer/UnitTestCodeful
from
samikay101:testClassFolderUpdates
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction output, add preview flag to create unit test from run and create blank unit test, remove option to create unit test from overview blade
…rkflow Synchronization
ccastrotrejo
requested changes
Feb 3, 2025
* @param error - The error to parse. | ||
* @returns {string} - A user-friendly error string. | ||
*/ | ||
export function parseErrorBeforeTelemetry(error: any): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add unit tests for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed? or is it a mock for some unit tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Item Links:
Type of Change
Current Behavior
New Behavior
1. Frontend: Remove Create Unit Test from Run Option in Overview Blade
2. [VS Code Extension] Add Telemetry for Create from Scratch
3. Add "(Preview)" to Create Unit Test Buttons
(Preview)
, signaling that the feature is in an experimental phase.4. Improve C# Class Folder Generation, Naming, and Workflow Synchronization
Restructuring C# Class Folder Hierarchy
MockOutputs
folder stores common C# classes shared across multiple unit tests.Preventing Duplicate C# Classes for the Same Operation
ReadAResourceGroup
, all instances will now reference a single class (ReadAResourceGroupMockOutput.cs
) instead of creating unnecessary duplicates (ReadAResourceGroup1.cs
,ReadAResourceGroup2.cs
, etc.).Standardizing Naming for Generated C# Classes
"MockOutput"
to generated C# classes.ReadAResourceGroup.cs
→ReadAResourceGroupMockOutput.cs
WhenAHTTPRequestIsReceived.cs
→WhenAHTTPRequestIsReceivedMockOutput.cs
Expected Outcome
Impact of Change
No breaking changes expected. The changes improve functionality, telemetry tracking, and organization.
Test Plan
[Frontend] Remove Create Unit Test from Run Option in Overview Blade
[VS Code Extension] Add Telemetry for Create from Scratch
apps/vs-code-designer/src/app/utils/codeful/saveBlankUnitTest.test.ts
.[VS Code Extension] Add "(Preview)" to Create Unit Test Buttons
[Improve C# Class Folder Generation, Naming, and Workflow Synchronization]
apps/vs-code-designer/src/app/utils/codeful/saveBlankUnitTest.test.ts
.MockOutputs
folder.MockOutput
suffix) are correctly applied.Screenshots or Videos (if applicable)
Before and After Screenshots: Remove Create Unit Test from Run Option in Overview Blade
Before:
After:
Before and After Screenshots: Add "(Preview)" to Create Unit Test Buttons
Before:
After:
Additional Notes