Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Improve Logic Apps sites API call #3338

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Sep 18, 2023

Main Code Chages

  • Update create client logic to fetch Logic Apps. This just make one single API call to fetch all of them instead of fetching 1 by one. This reduces the time it takes to load the LAs in the Resource tab and when trying to deploy.
  • Test Subscription was BTS4 which has around 750 Logic Apps. Last implementation would take ~ 30 minutes or more. New implementation takes ~1 minute.
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

Fixes #2505

@ccastrotrejo ccastrotrejo enabled auto-merge (squash) September 18, 2023 20:17
@ccastrotrejo ccastrotrejo merged commit abe421a into main Sep 18, 2023
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/extensionImprovements branch September 18, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS code: Taking longer time to load logic apps in resources blade and creating the logic apps from it.
2 participants