Skip to content

Bump node version in test pipeline and exe script #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EmmaZhu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump node version in test pipeline and exe script #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 54 additions & 54 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
vmImage: "ubuntu-20.04"
strategy:
matrix:
node_22_x:
node_version: 22.x
node_20_x:
node_version: 20.x
node_14_x:
Copy link
Member

@blueww blueww Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is actually not used in test now.

The test already move to github action, the test config file is : https://github.com/Azure/Azurite/blob/main/.github/workflows/PrValidation.yml

node_version: 14.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -50,10 +50,10 @@ jobs:
vmImage: "ubuntu-latest"
strategy:
matrix:
node_16_x:
node_version: 16.x
node_18_x:
node_version: 18.x
node_22_x:
node_version: 22.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -83,10 +83,10 @@ jobs:
vmImage: "windows-latest"
strategy:
matrix:
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -116,10 +116,10 @@ jobs:
vmImage: "macOS-latest"
strategy:
matrix:
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -149,10 +149,10 @@ jobs:
vmImage: "ubuntu-latest"
strategy:
matrix:
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_24_x:
node_version: 24.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -184,10 +184,10 @@ jobs:
vmImage: "ubuntu-latest"
strategy:
matrix:
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -217,10 +217,10 @@ jobs:
vmImage: "windows-latest"
strategy:
matrix:
node_16_x:
node_version: 16.x
node_18_x:
node_version: 18.x
node_22_x:
node_version: 22.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -250,10 +250,10 @@ jobs:
vmImage: "macOS-latest"
strategy:
matrix:
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_24_x:
node_version: 24.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -284,10 +284,10 @@ jobs:
strategy:
matrix:
# Table tests no longer support older node versions
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -318,10 +318,10 @@ jobs:
strategy:
matrix:
# Table tests no longer support older node versions
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_20_x:
node_version: 20.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -352,10 +352,10 @@ jobs:
strategy:
matrix:
# Table tests no longer support older node versions
node_16_x:
node_version: 16.x
node_18_x:
node_version: 18.x
node_22_x:
node_version: 22.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -390,8 +390,8 @@ jobs:
# Track with https://github.com/Azure/Azurite/issues/1550. Will add node 14 back later when the issue resolved.
#node_14_x:
# node_version: 14.x
node_16_x:
node_version: 16.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -436,10 +436,10 @@ jobs:
strategy:
matrix:
# Table tests no longer support older node versions
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_24_x:
node_version: 24.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -484,10 +484,10 @@ jobs:
strategy:
matrix:
# Table tests no longer support node_8_x
node_14_x:
node_version: 14.x
node_16_x:
node_version: 16.x
node_22_x:
node_version: 22.x
node_20_x:
node_version: 20.x
steps:
- task: NodeTool@0
inputs:
Expand Down Expand Up @@ -594,8 +594,8 @@ jobs:
# our .exe build program is currently incompatible with node 10
# node_10_x:
# node_version: 10.x
node_18_x:
node_version: 18.x
node_22_x:
node_version: 22.x
steps:
- task: NodeTool@0
inputs:
Expand Down
2 changes: 1 addition & 1 deletion scripts/buildExe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const pkgFetch = require('pkg-fetch');
build();

async function build() {
const pkgTarget = 'node18-win-x64';
const pkgTarget = 'node22-win-x64';
Copy link
Member

@blueww blueww Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure looks is caused by 'pkg-fetch' not support node 22.
https://www.npmjs.com/package/pkg-fetch/v/3.5.2?activeTab=readme

There are other similar tool support node 22 like https://www.npmjs.com/package/@yao-pkg/pkg-fetch?activeTab=readme

We might can consider upgrade to node 22 in the future release.

const cacheExe = await downloadCache(pkgTarget);
await rcedit(cacheExe, {
"version-string": {
Expand Down
Loading