-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Change 2 #13384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Change 2 #13384
Conversation
|
@yeger00 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
…ent isolated script execution Changes: - Changed pull_request to pull_request_target for better security context - Added comprehensive security check job to detect: * Symlinks in PR files (git ls-files check) * Suspicious '*-linked' directories (pattern matching) * Executable scripts outside allowed directories (allowlist) - Replaced all vulnerable inline script execution with: * Isolated temp directory execution * Script download from master branch only * Python isolation flags (-I -s) for pip install * PowerShell isolated execution with cleanup - Updated approval comments with symlink detection guidance - Prevents symlink attack vectors like PR #13384
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.