Track go fm package usage and version by env var #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniwang
reviewed
Sep 15, 2025
| LoadBalancingEnabledTag = "LB" | ||
|
|
||
| // Feature flag usage tracing | ||
| FMPackageName = "FEATURE_MANAGEMENT_GO" |
Member
There was a problem hiding this comment.
suggest using MS_FEATURE_MANAGEMENT_GO_VERSION for reasons:
- Adding scoped
MS_prefix to minimize the chance of conflict. A general name is easier to be overwriten or misused. - Its value is actually a version number, hence including
VERSION
juniwang
reviewed
Sep 15, 2025
|
|
||
| // Feature flag usage tracing | ||
| FMPackageName = "FEATURE_MANAGEMENT_GO" | ||
| FMVersionKey = "FMGoVersion" |
Member
There was a problem hiding this comment.
FMGoVer? we use abbr Ver in other keys.
Member
There was a problem hiding this comment.
Junbo suggests using FMGoVer as key name, not sure what key we use in other languages. please consider it, the key point is consistency.
Member
Author
There was a problem hiding this comment.
Oh I see, updated to FMGoVer. (JS: FMJsVer, AspNetCore: FMANCVer)
RichardChen820
approved these changes
Sep 24, 2025
Member
|
approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.