chore(linux): simplify API server outbound connection check logic#8523
Merged
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Simplifies the API server outbound connection check by consolidating the API_SERVER_CONN_RETRIES assignment into the FQDN branch, avoiding a redundant *.privatelink.* regex comparison.
Changes:
- Moved
API_SERVER_CONN_RETRIES=50inside the FQDN (non-IP) branch. - Moved the privatelink override of
API_SERVER_CONN_RETRIES=100into the existing privatelink conditional. - Relocated
VALIDATION_ERR=0and the TODO comment.
lilypan26
approved these changes
May 14, 2026
Devinwong
approved these changes
May 14, 2026
awesomenix
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
simplify API server outbound connection check logic to reduce API_SERVER_NAME regex comparisons and improve readability
Which issue(s) this PR fixes:
Fixes #