-
Notifications
You must be signed in to change notification settings - Fork 241
feat: add ServiceAccountImagePullProfile for identity-binding-based image pull #7596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qweeah
wants to merge
2
commits into
main
Choose a base branch
from
qweeah/ibip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This PR's logic LGTM. But I don't quiet understand what is step 2 "RP integration and configuration flow". Agentbaker won't rely on anything from AKS RP, I think you could make all changes in the same PR and add E2E for it? Here is an example PR: #7059 . |
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
1a47af0 to
67be361
Compare
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for service-account-based image pull authentication (aka Identity Binding) from Azure Container Registry (ACR), implementing KEP-4412 projected service account tokens for kubelet image credential providers.
Changes
Data Model
Added
ServiceAccountImagePullProfiletoSecurityProfilewith fields:Enabled: Enable/disable service account-based image pullDefaultClientID: Default managed identity client IDDefaultTenantID: Default managed identity tenant IDLocalAuthoritySNI: SNI endpoint for Identity Bindings Local AuthorityAdded getter methods to
SecurityProfilefor null-safe access.Implementation Paths
1. Legacy CSE (Template-based)
pkg/agent/variables.go: Template variables for CSE scripts (using the naming conventionserviceAccountImagePull...)parts/linux/cloud-init/artifacts/cse_cmd.sh: Environment variable declarations (e.g.,SERVICE_ACCOUNT_IMAGE_PULL_ENABLED,SERVICE_ACCOUNT_IMAGE_PULL_DEFAULT_CLIENT_ID)parts/linux/cloud-init/artifacts/cse_config.sh: Credential provider config generation2. AKSNodeConfig (Proto-based)
aks-node-controller/proto/aksnodeconfig/v1/security_profile.proto: Proto definitions (ServiceAccountImagePullProfile)aks-node-controller/parser/parser.go: Environment variable generationaks-node-controller/parser/helper.go: Null-safe helper functionsBoth paths converge at
cse_config.shto generate/var/lib/kubelet/credential-provider-config.yamlwith identity binding arguments (--ib-default-client-id,--ib-default-tenant-id,--ib-sni-name) and token attributes.Testing
variables_test.go,datamodel/types_test.go, andparser/helper_test.goto reflect the new naming convention.pkg/agent/testdata(117 files) to reflect the newSERVICE_ACCOUNT_IMAGE_PULL_environment variables.All tests validate that the credential provider config file contains the correct identity binding configuration.
Cluster Support
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Dual implementation approach (legacy CSE + modern AKSNodeConfig) for backward compatibility. Both paths are fully tested and generate identical credential provider configuration. The renaming from
ImagePullIdentitytoServiceAccountImagePullensures consistency with the upstream feature name.Release note: