fix: fixing repodepot support for azlinux3 and ubuntu2404 as well as PMC on Ubuntu #7565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsly
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
awesomenix
requested changes
Dec 18, 2025
| cloud-init status --wait | ||
|
|
||
| function init_mariner_repo_depot { | ||
| local repodepot_endpoint=$1 |
Contributor
There was a problem hiding this comment.
is this copied from somewhere? Can you please add the source?
Collaborator
Author
There was a problem hiding this comment.
which part are you asking if it's copied ?
| IS_MARINER=1 | ||
| elif [[ $NAME == *"Microsoft Azure Linux"* ]]; then | ||
| IS_AZURELINUX=1 | ||
| else |
Contributor
There was a problem hiding this comment.
i see that below you have mentioned
no customization
Can we keep the behaviour consistent, like log a error message/warning that we cannot determine the distribution and customization may not be applied. i feel exit 1 is a bit extreme
awesomenix
approved these changes
Jan 8, 2026
… and all AzLinux version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
fixing repodepot support for azlinux3 and ubuntu2404 as well as PMC on Ubuntu
Requirements:
Special notes for your reviewer:
Release note: