Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openai module and add network link #42

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions infra/network.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,16 @@ module "vnet" {
virtual_network_address_space = ["10.52.0.0/16"]
virtual_network_location = var.region
virtual_network_name = "vnet"
}

resource "azurerm_private_dns_zone" "zone" {
name = "privatelink.openai.azure.com"
resource_group_name = azurerm_resource_group.this.name
}

resource "azurerm_private_dns_zone_virtual_network_link" "link" {
name = "openai-private-dns-zone"
private_dns_zone_name = azurerm_private_dns_zone.zone.name
resource_group_name = azurerm_resource_group.this.name
virtual_network_id = module.vnet.vnet_id
}
58 changes: 37 additions & 21 deletions infra/openai.tf
Original file line number Diff line number Diff line change
@@ -1,38 +1,54 @@
resource "random_integer" "this" {
max = 999999
min = 100000
}

module "openai" {
source = "Azure/openai/azurerm"
version = "0.1.3"
source = "Azure/avm-res-cognitiveservices-account/azurerm"
version = "0.4.0"
kind = "OpenAI"
name = "azure-openai-${random_integer.this.result}"
soferreira marked this conversation as resolved.
Show resolved Hide resolved
resource_group_name = azurerm_resource_group.this.name
sku_name = "S0"
location = azurerm_resource_group.this.location
private_endpoint = {
private_endpoints = {
"pe_endpoint" = {
private_dns_entry_enabled = true
dns_zone_virtual_network_link = "dns_zone_link_openai"
is_manual_connection = false
name = "openai_pe"
private_dns_zone_resource_ids = toset([azurerm_private_dns_zone.zone.id])
private_service_connection_name = "openai_pe_connection"
subnet_name = "subnet0"
vnet_name = module.vnet.vnet_name
vnet_rg_name = azurerm_resource_group.this.name
subnet_resource_id = module.vnet.vnet_subnets_name_id["subnet0"]
}
}
deployment = {
cognitive_deployments = {
"chat_model" = {
name = var.chat_model_name
model_format = "OpenAI"
model_name = var.chat_model_name
model_version = var.chat_model_version
scale_type = var.scale_type
capacity = 30
model = {
format = "OpenAI"
name = var.chat_model_name
version = var.chat_model_version
}
scale = {
capacity = 120
type = var.scale_type
}
},
"embedding_model" = {
name = "text-embedding-ada-002"
model_format = "OpenAI"
model_name = "text-embedding-ada-002"
model_version = "2"
scale_type = "Standard"
capacity = 120
name = var.emb_model_name
model = {
format = "OpenAI"
name = var.emb_model_name
version = "2"
}
scale = {
capacity = 120
type = var.scale_type
soferreira marked this conversation as resolved.
Show resolved Hide resolved
}
},
}
network_acls = {
default_action = "Deny"
virtual_network_rules = toset([{subnet_id = module.vnet.vnet_subnets_name_id["subnet0"]}])
}
depends_on = [
azurerm_resource_group.this,
module.vnet
Expand Down
2 changes: 1 addition & 1 deletion infra/output.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ output "installation-script" {
{ resourceGroup = azurerm_resource_group.this.name,
aksName = module.aks.aks_name,
registry = azurerm_container_registry.acr.name,
endpoint = module.openai.openai_endpoint,
endpoint = module.openai.endpoint,
clientid = azurerm_user_assigned_identity.chatbot.client_id,
oidc_url = module.aks.oidc_issuer_url,
chat_model_name = var.chat_model_name
Expand Down
2 changes: 1 addition & 1 deletion infra/providers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ terraform {
}
random = {
source = "hashicorp/random"
version = "3.3.2"
version = "3.5.0"
}
}
}
Expand Down
10 changes: 10 additions & 0 deletions infra/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ variable "chat_model_version" {
default = "2024-08-06"
}

variable "emb_model_name" {
soferreira marked this conversation as resolved.
Show resolved Hide resolved
type = string
default = "text-embedding-ada-002"
}

variable "emb_model_version" {
soferreira marked this conversation as resolved.
Show resolved Hide resolved
type = string
default = "2"
}

variable "scale_type" {
type = string
description = "values: GlobalStandard, Standard"
Expand Down