-
Notifications
You must be signed in to change notification settings - Fork 104
Citadel v1 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohamedsaif
wants to merge
42
commits into
Azure-Samples:citadel-v1
Choose a base branch
from
mohamedsaif:citadel-v1
base: citadel-v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Citadel v1 #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces major enhancements to the AI infrastructure provisioning scripts, focusing on onboarding use cases for the AI Hub Gateway, expanding support for new services (AI Foundry, API Center), and improving resource configuration flexibility and security defaults. The changes include a comprehensive onboarding guide, new parameters and configuration for AI Foundry and API Center, dynamic backend/model configuration, and updates to networking and monitoring modules.
AI Hub Gateway Onboarding Documentation:
guides/Citadel-Access-Contracts.md) that explains how to automate use-case onboarding for AI Hub Gateway, including visual diagrams, folder structure, parameters, outputs, customization, troubleshooting, and a practical Financial Assistant example.Support for New Services and Resource Configuration:
apicServiceName,apicSku, abbreviation ininfra/abbreviations.json) and AI Foundry (aiFoundryResourceName,enableAIFoundry,aiFoundryInstances,aiFoundryModelsConfig) to support their deployment and integration. [1] [2] [3] [4] [5]Dynamic Model and Backend Configuration:
openAiInstancesobject and replaced with dynamic arrays for AI Foundry and AI Search instances, plus a flexibleaiFoundryModelsConfigarray to specify model deployments per Foundry instance.Networking and Security Improvements:
privatelink.services.ai.azure.com) and ensured DNS modules receive tags for better resource tracking. [1] [2] [3]Disabledfor improved security, and updated APIM SKU default toStandardV2. [1] [2]Monitoring and Observability Enhancements:
These changes collectively provide a scalable, secure, and flexible foundation for onboarding AI use cases and integrating new AI services into the APIM-based gateway architecture.