Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #53

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Improvements #53

merged 4 commits into from
Jul 19, 2024

Conversation

john0isaac
Copy link
Collaborator

@john0isaac john0isaac commented Jul 19, 2024 •
edited
Loading

Purpose

This PR updates the notebook content to match the flow of the web app, and uses url.parse.quote_plus to parse the mongo db username and password, and remove unnecessary bicep.

Does this introduce a breaking change?

- [ ] Yes
- [x] No

Pull Request Type

What kind of change does this Pull Request introduce?

- [x] Bugfix
- [ ] Feature
- [x] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Documentation content changes
- [ ] Other... Please describe:

@john0isaac john0isaac self-assigned this Jul 19, 2024
@john0isaac john0isaac changed the title update notebook and use url.parse Improvements Jul 19, 2024
@john0isaac john0isaac merged commit 9936b20 into main Jul 19, 2024
7 checks passed
@john0isaac john0isaac deleted the fix-url-parse branch July 19, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@john0isaac john0isaac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@john0isaac