Repository navigation
fix(indexer): treat a ready A/B builder as done even if it resumed - #131
Merged
Merged
Conversation
box-deploy waited for the builder to log 'Completed backfill indexing'. Ponder prints that line only when it builds a schema from scratch. Rerunning a deploy with the same NEW_SCHEMA restarts the builder on a schema that is already built, so Ponder resumes, never prints the line, and the script sits out its full 45-minute timeout before giving up. That is what happened on the second atp-indexer-si-v3 attempt, with prod already down. The wait now also accepts the builder's /ready, which Ponder serves once historical indexing is caught up whichever way it got there. The log check stays as well, in case /ready is slow to answer on a fresh build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rerunning a deploy with the same
new_schemahangs for the full 45-minute timeout. The builder resumes the schema it already built, and Ponder doesn't print 'Completed backfill indexing' on a resume. That's how the secondatp-indexer-si-v3attempt failed.The wait loop now also checks the builder's
/readyon port 42069. The log check is kept.