Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

balazs92117
Copy link

The CLI is not copied to the container. This commit fixes it.

The CLI is not copied to the container. This commit fixes it.
@balazs92117
Copy link
Author

@bert-laverman pls take a look.

Copy link

@bert-laverman bert-laverman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. This is an old debate. The problem is that you don't have a shell when using a distroless base image, so how will you run the CLI? Probably the best is to have a dedicated CLI image based on distroless, so you can run that without having to "exec" into the Axon Server container.

@balazs92117
Copy link
Author

You have -debug versions of the base image, which has shell (bash). But at this point I'm not sure if this is the right source repository for https://hub.docker.com/r/axoniq/axonserver-enterprise/tags

@bert-laverman
Copy link

You have -debug versions of the base image, which has shell (bash). But at this point I'm not sure if this is the right source repository for https://hub.docker.com/r/axoniq/axonserver-enterprise/tags

Actually, the "-debug" images of distroless don't have a real shell, but more something that resembles the minimal one from busybox. The official Axon Server images use the Eclipse Temurin images, which contain bash, but those images are managed somewhere else. The "Running Axon Server" repository is there to provide examples.

Still, a separate Axon Server CLI image might be useful to add. I'll have a look if we can add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants