feat(theme): set the body background color #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
requested review from
jordan-a-young,
LauRoxx and
gregmartDOTin
as code owners
|
gregmartDOTin
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently everyone would need to set the body background color on their own. This means everyone has to realize this needs to be done and determine how to do this on their own. Most developers using workflow and coming from uikit will probably opt to updating the scss, but you can't (easily) pull the token values into scss so they will most likely hardcode it. To avoid hardcoding this commonly used body background color, it should just default to it.
Supersedes #639