Feat/page header logo #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmartDOTin
requested review from
jordan-a-young and
LauRoxx
as code owners
|
| @@ -12,6 +12,7 @@ type BaseSpacesImageProps = { | |||
| | 'images.promotionalHover'; | |||
| fallback?: string; | |||
| id?: string; | |||
| Loader?: (props: any) => JSX.Element; | |||
There was a problem hiding this comment.
Since we're passing an id to the Loader I think we should set the type for props as { id: string } instead of any
There was a problem hiding this comment.
Good call, this is fixed.
jordan-a-young
approved these changes
Nov 6, 2024
BREAKING CHANGE: helpLink and helpAppName removed in favor of the help object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.