Skip to content

Commit

Permalink
chore: drop node 16 support and add node 18 & 20 support
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Dropped support for Node 16
  • Loading branch information
gregmartDOTin committed Apr 17, 2024
1 parent ff86bb0 commit 1a09db5
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This monorepo is managed using [yarn](https://yarnpkg.com/getting-started) and [

## Installation

The currently recommended version of node to use when developing in this repo is: `v16.16.0`. We recommend using [fnm](https://github.com/Schniz/fnm#readme) to have your node version automatically changed when you `cd` into the repo.
The currently recommended version of node to use when developing in this repo is: `v20`. We recommend using [fnm](https://github.com/Schniz/fnm#readme) to have your node version automatically changed when you `cd` into the repo.

We use `yarn berry` (aka yarn v3) to manage dependencies. Install `yarn` globally:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/commitlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'

- run: yarn install --immutable

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Set Node Version
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand All @@ -37,9 +37,9 @@ jobs:
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-16-yarn-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-20-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-16-yarn-
${{ runner.os }}-20-yarn-
- name: Install Dependencies
run: yarn install --immutable
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Set Node Version
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand All @@ -79,9 +79,9 @@ jobs:
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-16-yarn-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-20-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-16-yarn-
${{ runner.os }}-20-yarn-
- name: Install Dependencies
run: yarn install --immutable
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
node: [16]
node: [18, 20]

steps:
- name: Checkout Code
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Set Node Version
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache directory path
id: yarn-cache-dir-path
Expand All @@ -39,9 +39,9 @@ jobs:
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-16-yarn-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-20-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-16-yarn-
${{ runner.os }}-20-yarn-
- name: Install Dependencies
run: yarn install --immutable
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.16.0
20
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const App = () => {

## Development

The currently recommended version of node to use when developing in this repo is: `v16.16.0`. We recommend using [fnm](https://github.com/Schniz/fnm#readme) to have your node version automatically changed when you `cd` into the repo.
The currently recommended version of node to use when developing in this repo is: `v20`. We recommend using [fnm](https://github.com/Schniz/fnm#readme) to have your node version automatically changed when you `cd` into the repo.

We use `yarn berry` (aka yarn v3) to manage dependencies. Install `yarn` globally:

Expand Down
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
command = "yarn build:storybook:ci"

[build.environment]
NODE_VERSION = "16"
NODE_VERSION = "20"
YARN_VERSION = "1.19.1"

[[redirects]]
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"engines": {
"yarn": "^3.0.0",
"node": "^16.0.0"
"node": "^18.0.0 | ^20.0.0"
},
"scripts": {
"build": "nx run-many --target=build --all",
Expand Down

0 comments on commit 1a09db5

Please sign in to comment.