Transform dependencies in node_modules #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting work on #212
chrishavekost
requested review from
robmcguinness,
nylon22 and
jordan-a-young
chrishavekost
commented
Dec 4, 2020
chrishavekost
force-pushed
the
fix/ie11-arrow
branch
from
9937248 to
1fb35ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main portion of this PR deals with having
babel-loadertranspile dependencies inside node_modules. As time goes on, more packages are moving to modern syntax not supported in IE 11. As we upgrade Availity packages we are running into more problems in IE 11. Having babel process dependencies should help.This PR also has some cacheGroup changes and a regex fix.
I also plan to add some of the more common polyfills we are missing in a separate PR. As an example,
@availity/hooksdepends onreact-querywhich now needsArray.prototype.includes()to be polyfilled, that should no longer be on the developer to add. I plan to add a few more common ones plus some bundle size comparisons in that PR too.References #212 and #98