-
Notifications
You must be signed in to change notification settings - Fork 103
CANTINA-913: Match protocol in CORS header #4964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only allow HTTPS origins on VIP
6096a11
to
13090b5
Compare
a70ce23
to
3f8bf14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4964 +/- ##
=============================================
+ Coverage 30.42% 30.44% +0.02%
Complexity 4826 4826
=============================================
Files 290 290
Lines 21329 21321 -8
=============================================
+ Hits 6489 6492 +3
+ Misses 14840 14829 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c13bc7d
to
7090ecf
Compare
7090ecf
to
4bcb875
Compare
Co-authored-by: Volodymyr Kolesnykov <[email protected]>
This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed. This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved. |
|
Per Slack conversation with @rebeccahum this is not blocked anymore. |
Description
Only allow HTTPS origins on VIP
Changelog Description
Filter added: vip_only_https_origins
Only allow HTTPS origins on VIP
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
curl 'https://example.net/wp-admin/admin-ajax.php?action=heartbeat' -H 'Origin: http://example.net' -I
and expect to seeaccess-control-allow-origin
returnedaccess-control-allow-origin
returned