Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANTINA-852: do not alter meta_key index for large tables #2893

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Feb 11, 2022

Check the size of the wp_postmeta table before attempting to modify the meta_key index.

@sjinks sjinks requested a review from a team as a code owner February 11, 2022 10:58
schema.php Outdated Show resolved Hide resolved
@sjinks
Copy link
Member Author

sjinks commented Feb 11, 2022

To add the index to a large table:

ALTER TABLE wp_postmeta LOCK=NONE, ALGORITHM=NOCOPY, ADD KEY vip_meta_key_value (meta_key(191), meta_value(100));
ALTER TABLE wp_postmeta LOCK=NONE, ALGORITHM=NOCOPY, DROP KEY meta_key, ADD KEY meta_key (meta_key(191), meta_value(100));
ALTER TABLE wp_postmeta LOCK=NONE, ALGORITHM=NOCOPY, DROP KEY vip_meta_key_value;

@sjinks sjinks marked this pull request as draft February 11, 2022 19:24
@sjinks sjinks marked this pull request as ready for review February 14, 2022 17:18
schema.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #2893 (82f1133) into develop (82f1133) will not change coverage.
The diff coverage is n/a.

❗ Current head 82f1133 differs from pull request most recent head 4effbef. Consider uploading reports for the commit 4effbef to get more accurate results

@@            Coverage Diff             @@
##             develop    #2893   +/-   ##
==========================================
  Coverage      34.62%   34.62%           
  Complexity      3603     3603           
==========================================
  Files            216      216           
  Lines          13920    13920           
==========================================
  Hits            4820     4820           
  Misses          9100     9100           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sjinks sjinks force-pushed the develop branch 2 times, most recently from 529fa93 to 1ac9637 Compare July 26, 2022 10:59
@github-actions
Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sjinks sjinks force-pushed the develop branch 2 times, most recently from deded3c to b235946 Compare November 14, 2022 20:51
@github-actions
Copy link
Contributor

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants