Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Booknest: add theme #8689

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Booknest: add theme #8689

merged 6 commits into from
Feb 14, 2025

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Feb 7, 2025

Booknest is a clean, user-friendly theme designed for book clubs and readers. Easily organize events, share reviews, and build a vibrant community of literature lovers.

Some color palettes may still be changed, but the overall design decisions are defined.

Demo site | Demo content export

screenshot

@henriqueiamarino henriqueiamarino self-assigned this Feb 7, 2025
@henriqueiamarino henriqueiamarino added the Waiting Review Add this label if this is the first PR for a new theme label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Preview changes

I've detected changes to the following themes in this PR: Booknest.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi
Copy link
Contributor

Reviewing now.

@iamtakashi iamtakashi added Under Review It's being reviewed atm. and removed Waiting Review Add this label if this is the first PR for a new theme labels Feb 13, 2025
@iamtakashi
Copy link
Contributor

This theme uses blocks creatively. Thanks for reviewing the checklist before the review. It was very helpful, as I only spotted a few things to mention here.

  • The mobile menu bumps the edges. This is because the unitless value in styles.spacing.padding.top.
    CleanShot 2025-02-13 at 12 20 00@2x
    CleanShot 2025-02-13 at 12 20 16@2x
  • Let's normalise the various side paddings in the single-post template.
    CleanShot 2025-02-13 at 12 33 22@2x
  • The size of the navigation block is modified locally in both header template parts. If that's the desired size in this theme, let's change it globally.
    CleanShot 2025-02-13 at 12 44 55@2x
  • Remove unused Inclusive Sans
  • Remove the git files from trispace-semicondensed. If you don't see them, you can make hidden files visible with a shortcut.
    CleanShot 2025-02-13 at 13 00 30@2x
  • FYI: There is a bug in CBT, and it doesn't internationalise the summary text in the Details block. I manually internationalised them and pushed a fix.

@iamtakashi
Copy link
Contributor

Thanks for the update. All are fixed except for the site title on the single post template. I didn't think it was intentional, but let me know.
CleanShot 2025-02-14 at 16 09 08@2x

@iamtakashi
Copy link
Contributor

We've discussed the site title and decided to leave it as it is. Merging!

@iamtakashi iamtakashi merged commit 0936386 into trunk Feb 14, 2025
1 check passed
@iamtakashi iamtakashi deleted the add/booknest branch February 14, 2025 17:16
@iamtakashi iamtakashi removed the Under Review It's being reviewed atm. label Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants