Add simple server functionality and integrate with UI #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a SimpleServer class to manage starting and stopping a server. - Added openSimpleServer function in ipc-handlers to handle server requests. - Integrated a button in the Header component to open the simple server. - Created tests for the SimpleServer class and the openSimpleServer function to ensure proper functionality. - Updated preload script to expose the new openSimpleServer API method.
ramonjd
commented
Mar 28, 2025
| this.port = await portFinder.getOpenPort(); | ||
|
|
||
| // Add a basic route handler | ||
| app.get( '/', ( req, res ) => { |
There was a problem hiding this comment.
I tried a node-based sql gui module, but it didn't work at all.
Looking at some static viewers, which we can serve from app.use( express.static( path.join( __dirname, '../../vendor/sql-viewer/public' ) ) ); or somewhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1112
Just a simple server for now to test serving up a static sqlite gui app.
Testing a few pre-built apps.
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist