Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio: Use feature flag to force the modal #1138

Closed

Conversation

katinthehatsite
Copy link
Contributor

Related issues

STU-271

Proposed Changes

This PR adds forces the modal for when whatsNewSectionEnabled feature flag is set to true to be able to force it with app versions that are not included for automatic triggering of the modal.

Testing Instructions

  • Pull the changes from this branch
  • Apply the following diff:
index cc090c42..3324682f 100644
--- a/src/ipc-handlers.ts
+++ b/src/ipc-handlers.ts
@@ -784,7 +784,7 @@ export async function getAppGlobals( _event: IpcMainInvokeEvent ): Promise< AppG
                appVersion: app.getVersion(),
                arm64Translation: app.runningUnderARM64Translation,
                terminalWpCliEnabled: process.env.STUDIO_TERMINAL_WP_CLI === 'true',
-               whatsNewSectionEnabled: process.env.STUDIO_WHATS_NEW_SECTION === 'true',
+               whatsNewSectionEnabled: true,
        };
 }
  • Start the app with npm start
  • Confirm that you see the modal when the app starts
  • Confirm that the modal closes correctly

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@katinthehatsite katinthehatsite self-assigned this Mar 27, 2025
@katinthehatsite
Copy link
Contributor Author

One disadvantage of this approach is that if the user restarts the app, they will see the modal again because we are using the local state to track if they saw it.

@katinthehatsite
Copy link
Contributor Author

Let's close this as we decided on a different approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant