Forms: Add list responses ability #45810
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
bot
added
the
[Status] Needs Author Reply
Code Coverage SummaryCoverage changed in 1 file.
1 file is newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
CGastrell
left a comment
CGastrell
left a comment
There was a problem hiding this comment.
Worked well in tandem with MCP setup!
| public static function register_category() { | ||
| if ( function_exists( 'wp_register_ability_category' ) ) { | ||
| wp_register_ability_category( | ||
| 'jetpack-forms', |
There was a problem hiding this comment.
I recommend using a class constant here and elsewhere.
| 'blog_id' => array( | ||
| 'type' => 'string', | ||
| 'description' => 'Site ID (numeric) or site URL to get form responses from. Defaults to current site if not specified.', | ||
| ), |
There was a problem hiding this comment.
There's been some discussion around this — whether abilities themselves should have inputs for things like blog_id — as opposed to letting the implementing code handle which blog is active.
Is there a specific purpose for this in this context?
Co-authored-by: Jason Adams <[email protected]>
Add Abilities API integration for Jetpack Forms
Proposed changes:
Abilitiesclass to register Jetpack Forms abilities with the Abilities APIjetpack/list-form-responsesability to retrieve form responsesjetpack-formsfor organizing Jetpack Forms abilitiesOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No, this PR only adds an API integration layer. It doesn't change what data we track or collect.
Testing instructions:
See wpcom-195631