-
Notifications
You must be signed in to change notification settings - Fork 826
Forms: Start using the new feedback version v3 #45047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replaces manual construction and insertion of feedback posts with a call to the response object's save() method, simplifying the code and improving maintainability. Also updates a test to use unescaped apostrophes in the subject assertion.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as expected
* Forms: Finally store the feedback in the new format Replaces manual construction and insertion of feedback posts with a call to the response object's save() method, simplifying the code and improving maintainability. Also updates a test to use unescaped apostrophes in the subject assertion. * changelog
Reverts #44925
Following #44927
Proposed changes:
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Same as #44889
Add a new form. With all the fields does the data get stored in the new format?
Are you still able to see the data in the responses tab in the back end?
Are you able to see the data in export. Do you still get the email notification?
Do you notice any PHP Errors?
Test the form by submitting Unicode characters as well as new lines and notice that you see them in the backend as expected.