Skip to content

Conversation

enejb
Copy link
Member

@enejb enejb commented Sep 2, 2025

Reverts #44925

Following #44927

Proposed changes:

  • Revert saving feedback into the new V3 format.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Same as #44889

Add a new form. With all the fields does the data get stored in the new format?
Are you still able to see the data in the responses tab in the back end?
Are you able to see the data in export. Do you still get the email notification?
Do you notice any PHP Errors?

Test the form by submitting Unicode characters as well as new lines and notice that you see them in the backend as expected.

Replaces manual construction and insertion of feedback posts with a call to the response object's save() method, simplifying the code and improving maintainability. Also updates a test to use unescaped apostrophes in the subject assertion.
@enejb enejb requested a review from a team September 2, 2025 20:47
@enejb enejb added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Package] Forms labels Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-switch-to-v3 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-switch-to-v3

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Sep 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link

jp-launch-control bot commented Sep 2, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form.php 573/1047 (54.73%) -0.56% 0 💚

Full summary · PHP report · JS report

@enejb enejb changed the title Update/forms switch to v3 Forms: Start using the new feedvack version v3 Sep 2, 2025
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@enejb enejb merged commit c28d353 into trunk Sep 3, 2025
74 of 76 checks passed
@simison simison changed the title Forms: Start using the new feedvack version v3 Forms: Start using the new feedback version v3 Sep 3, 2025
@enejb enejb deleted the update/forms-switch-to-v3 branch September 3, 2025 17:52
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 3, 2025
enejb added a commit that referenced this pull request Sep 3, 2025
kangzj pushed a commit that referenced this pull request Sep 4, 2025
* Forms: Finally store the feedback in the new format

Replaces manual construction and insertion of feedback posts with a call to the response object's save() method, simplifying the code and improving maintainability. Also updates a test to use unescaped apostrophes in the subject assertion.

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Package] Forms [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants