Forms: Add integrations feature flag #45037

edanzer · 2025-09-01T19:42:20Z

Proposed changes:

BEFORE MERGING: We should merge 191699-ghe-Automattic/wpcom, which adds add_filter( 'jetpack_forms_enable-integrations', '__return_false' ); to WordPress.com. Otherwise as soon as this is merged, integrations will show there. I'd like to get this one merged to make testing the feature flag on WordPress.com easier as part of this PR.

Introduces a form integrations feature flag. This defaults to true. Going forward, if any environment (like WordPress.com or VIP, CIAB) wants to hide integrations, they can use the new filter: add_filter( 'jetpack_forms_is_integrations_enabled', '__return_false' );
Uses the new feature flag to determine if we show integrations in the form dashboard and form block (rather than checking other elements like isSimpleSite or canUserInstallPlugins).
Replaces a similar, existing feature flag in class-dashboard.php file. We need a flag plugin wide, not just in the dashboard.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Test default: Without any custom code for the feature flag, confirm that integrations interface shows in the forms dashboard and form block block.
Test hiding integrations: Turn off integrations with add_filter( 'jetpack_forms_is_integrations_enabled', '__return_false' );, and confirm you no longer see our integrations interface in the forms dashboard or form block.

github-actions · 2025-09-01T19:43:10Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/form-show-integrations-filter branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/form-show-integrations-filter

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-01T19:43:19Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-09-01T19:51:42Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	283/588 (48.13%)	-0.08%	1 ❤️‍🩹
projects/packages/forms/src/blocks/contact-form/edit.js	0/232 (0.00%)	0.00%	1 ❤️‍🩹
projects/packages/forms/src/class-jetpack-forms.php	8/22 (36.36%)	-1.73%	1 ❤️‍🩹
projects/packages/forms/src/dashboard/class-dashboard.php	0/107 (0.00%)	0.00%	-1 💚

Full summary · PHP report · JS report

edanzer · 2025-09-01T20:34:24Z

projects/packages/forms/src/blocks/contact-form/edit.js

+				};
+			},
+			[ clientId ]
+		);


If you are seeing a lot of changes here, try hiding white space on the diff. It's easier to read. We just remove canUserInstallPlugins here since we are using the feature flag instead of this permissions check.

edanzer · 2025-09-01T20:35:46Z

projects/packages/forms/src/blocks/contact-form/edit.js

@@ -755,7 +748,7 @@ function JetpackContactFormEdit( { name, attributes, setAttributes, clientId, cl
 						/>
 					</PanelBody>

-					{ ! isSimpleSite() && canUserInstallPlugins && (
+					{ showFormIntegrations && (


The main change. We no longer check ifSimpleSite or check permissions. We just the feature flag. Any given environment (WordPress.com, CIAB, VIP) is now responsible for turning this off if needed.

edanzer · 2025-09-01T20:36:15Z

projects/packages/forms/src/dashboard/class-dashboard.php

-	 * @var bool
-	 */
-	public static $show_integrations = false;
-


We're just replacing this with the new, more general feature flag / filter.

projects/packages/forms/src/class-jetpack-forms.php

CGastrell

Worked well for me. Good call on the function name change.

dhasilva

Working as expected

edanzer added 3 commits September 1, 2025 13:20

Add form integrations feature flag

4616ac9

Update filter name

19422bb

changelog

b532cfb

edanzer requested a review from a team September 1, 2025 19:42

edanzer self-assigned this Sep 1, 2025

edanzer added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Pri] Normal [Package] Forms labels Sep 1, 2025

github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 1, 2025

Update feature flag name

3902ddc

edanzer commented Sep 1, 2025

View reviewed changes

dhasilva reviewed Sep 1, 2025

View reviewed changes

projects/packages/forms/src/class-jetpack-forms.php Outdated Show resolved Hide resolved

Update method and filter name

6c7870f

CGastrell approved these changes Sep 1, 2025

View reviewed changes

dhasilva approved these changes Sep 1, 2025

View reviewed changes

edanzer mentioned this pull request Sep 8, 2025

Forms: Add plugin install permissions check #45063

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: Add integrations feature flag #45037

Forms: Add integrations feature flag #45037

Uh oh!

edanzer commented Sep 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

edanzer Sep 1, 2025

Uh oh!

edanzer Sep 1, 2025

Uh oh!

edanzer Sep 1, 2025

Uh oh!

Uh oh!

CGastrell left a comment

Uh oh!

dhasilva left a comment

Uh oh!

Uh oh!

Forms: Add integrations feature flag #45037

Are you sure you want to change the base?

Forms: Add integrations feature flag #45037

Uh oh!

Conversation

edanzer commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

edanzer Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

edanzer Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

edanzer Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CGastrell left a comment

Choose a reason for hiding this comment

Uh oh!

dhasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edanzer commented Sep 1, 2025 •

edited

Loading

github-actions bot commented Sep 1, 2025 •

edited

Loading

github-actions bot commented Sep 1, 2025 •

edited

Loading

jp-launch-control bot commented Sep 1, 2025 •

edited

Loading