Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not echo three dashes at the end of restore cache script #146

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Do not echo three dashes at the end of restore cache script #146

merged 2 commits into from
Feb 4, 2025

Conversation

wzieba
Copy link
Member

@wzieba wzieba commented Feb 4, 2025 •
edited
Loading

This conflicts with Buildkite's terminal-to-html render

Build with an issue

image

Fixed

image
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@wzieba
Do not echo three dashes at the end of restore cache script
31ecbdc 
This conflicts with Buildkite's terminal-to-html render
@dangermattic
Copy link

dangermattic commented Feb 4, 2025 •
edited
Loading

1 Warning
⚠️ Please add an entry in the CHANGELOG.md file to describe the changes made by this PR

Generated by 🚫 Danger

@wzieba wzieba added the bug Something isn't working label Feb 4, 2025
@wzieba wzieba marked this pull request as ready for review February 4, 2025 15:12
@ParaskP7
Copy link
Contributor

ParaskP7 commented Feb 4, 2025

How about doing the same for: save_gradle_dependency_cache#L28 🤔

@wzieba
Copy link
Member Author

wzieba commented Feb 4, 2025

sure - I think it's not that big of a problem, but nevertheless we can 👍

@wzieba
Don't add 3 dashes when saving cache as well
de2e75e 
As it collides with Buildkite terminal-to-html render
@wzieba wzieba merged commit 1373ca1 into trunk Feb 4, 2025
13 checks passed
@wzieba wzieba deleted the fix_restore_gradle_cache_echo branch February 4, 2025 15:51
@wzieba wzieba mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

@ParaskP7 ParaskP7 Awaiting requested review from ParaskP7

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wzieba @dangermattic @ParaskP7 @AliSoftware