Skip to content

Move the Upload Image button outside the border to match new designs #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

AdamGrzybkowski
Copy link
Contributor

Description

PART1/3

This PR moves the Upload Image button outside the border in the main picker page.

Before After
Screenshot 2025-04-23 at 13 58 13 Screenshot 2025-04-23 at 13 56 43

Testing Steps

There are screenshot tests, so you can check them but you can also verify in the demo app:

  1. Launch the QE
  2. Log in
  3. Confirm the button is outside the border
  4. Remove all photos (or log in with a different email)
  5. Confirm the empty state looks correct as well (see screenshots)
  6. Repeat with the vertical scrolling

@AdamGrzybkowski AdamGrzybkowski added the [Feature] Gravatar-Quickeditor Gravatar Quick Editor module label Apr 23, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Apr 23, 2025

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App NameGravatar Demo
Commit131c9ce
Direct Downloadgravatar-demo-prototype-build-pr612-131c9ce.apk

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🎉

One small unrelated detail I noticed while testing:

CleanShot.2025-04-28.at.23.51.21.mp4

On the vertical layout, there doesn't seem to be an animation after deleting an avatar

@AdamGrzybkowski
Copy link
Contributor Author

On the vertical layout, there doesn't seem to be an animation after deleting an avatar

You're correct! I will check it later separately. Thanks

@AdamGrzybkowski AdamGrzybkowski merged commit d43905d into feature/quick_editor_about_info Apr 29, 2025
14 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/GRA-25_picker branch April 29, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Gravatar-Quickeditor Gravatar Quick Editor module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants