Implement extension function to remove orphan words #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
Enhance
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/565_orphans
branch
2 times, most recently
from
1a74283 to
3b8a117
Compare
|
I like this in principle, but I'm not sure we need a new composable for that. We could just keep the extension function from this PR and apply it to every |
That makes sense, I will remove it. |
AdamGrzybkowski
force-pushed
the
adam/565_orphans
branch
from
3b8a117 to
ea2762a
Compare
AdamGrzybkowski
changed the title
mlumeau
reviewed
Jan 28, 2025
| @@ -0,0 +1,8 @@ | |||
| package com.gravatar.quickeditor.ui | |||
|
|
|||
| internal val String.removeOrphans: String | |||
There was a problem hiding this comment.
Can we add a unit test for this function?
AdamGrzybkowski
force-pushed
the
adam/565_orphans
branch
from
ea2762a to
7eba37b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #565
Description
This PR adds a String extension that inserts a non-breaking space before the last word to make sure no orphan words are left in the last line. It's used in the
QESectionMessageTesting Steps
Choose or upload your favorite avatar images and connect them to your email address.will never have orphans.