Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease the start padding around the x button in the AlertBanner #564

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Decrease the start padding around the x button in the AlertBanner #564

merged 1 commit into from
Jan 28, 2025

Conversation

AdamGrzybkowski
Copy link
Contributor

Closes #551

Description

This PR decreases the start padding of the x button in the AlertBanner.

Testing Steps

  1. Open the QE.
  2. Make sure you don't have an avatar selected (Delete a selected one).
  3. Confirm the spacing is now smaller. You can play with the device font scaling. It's super simple in AS Ladybug
Screenshot 2025-01-28 at 10 59 33

@AdamGrzybkowski AdamGrzybkowski added Bug Something isn't working [Feature] Gravatar-Quickeditor Gravatar Quick Editor module labels Jan 28, 2025
@AdamGrzybkowski AdamGrzybkowski added this to the 2.3.0 milestone Jan 28, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 28, 2025 •
edited
Loading

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
App Name Gravatar Demo
Commit8234088
Direct Downloadgravatar-demo-prototype-build-pr564-8234088.apk

mlumeau
mlumeau approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mlumeau mlumeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now!

@AdamGrzybkowski AdamGrzybkowski merged commit c8ac4dc into trunk Jan 28, 2025
17 checks passed
@AdamGrzybkowski AdamGrzybkowski deleted the adam/551_banner branch January 28, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlumeau mlumeau mlumeau approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working [Feature] Gravatar-Quickeditor Gravatar Quick Editor module
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

QuickEditor: A lot of space in the warning banner
3 participants
@AdamGrzybkowski @wpmobilebot @mlumeau