Show all avatars in the Profile card regardless of the rating #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
Bug
AdamGrzybkowski
commented
Jan 24, 2025
| @@ -50,6 +51,7 @@ internal fun ProfileCard( | |||
| avatarUrl( | |||
| AvatarQueryOptions { | |||
| preferredSize = sizePx | |||
| rating = ImageRating.X | |||
There was a problem hiding this comment.
@pinarol Is that the rating you're using in the iOS SDK?
There was a problem hiding this comment.
I suggest we rename rating to maxRating in AvatarQueryOptions. Currently, I think it's a bit confusing that devs may need to explicitly set the rating to X in a user's profile card, even though the avatar won't have this rating 99% of the time.
There was a problem hiding this comment.
I agree about it being confusing, but that would be a breaking change. We can't simply rename it.
As far as I'm aware the naming matches the URL query params on purpose and the docs mention how this works.
AdamGrzybkowski
force-pushed
the
adam/549_restricted_avatars
branch
from
1d0ccfa to
2111676
Compare
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
force-pushed
the
adam/549_restricted_avatars
branch
from
2111676 to
9a1d824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #549
Description
The profile card in the QE wouldn't show avatars that are not G-rated. This fixes the problem by updating the request URL param.
Testing Steps