Set the cache buster value in the initial state #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
Bug
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
|
Wouldn't it be simpler to set the default value in the |
0 is not a great cache buster, because it's not unique. If you try to do the testing steps quickly, you will see it doesn't fix the problem. |
mlumeau
approved these changes
Jan 24, 2025
AdamGrzybkowski
force-pushed
the
adam/548_initial_image_cached
branch
from
a12ca77 to
2652c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #548
Description
The cache buster param is not set when initializing the
AvatarPickerViewModelso we do load a cached image. This PR sets the value in the state initialization to fix that.Testing Steps