Deprecate GravatarQuickEditorActivity #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
[Feature] Gravatar-Quickeditor
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
AdamGrzybkowski
deleted the
adam/542_deprecate_GravatarQuickEditorActivity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542
Description
Now that this PR was merged we can deprecate the
GravatarQuickEditorActivity. Its only purpose was not to force third-party apps to set one of their activities to singleTask. Now that we will useGravatarOAuthActivityfor the OAuth flow, the singleTask needs to be set only on this activity so theGravatarQuickEditorActivityserves no purpose.I will update docs in a separate PRs.
Testing Steps
None, really.