Fix the QE recomposition when selecting an avatar

[AdamGrzybkowski]

Description

There's a bug that's causing the QE to reload on Avatar change. The problem is this line. When an avatar is selected the onAvatarSelected lambda is invoked and this triggered the recomposition caused by the changed startDestination.

Changing the start destination was convenient but not necessary, so I reworked the code to not require it.

Testing Steps

1. Launch the QE
2. Select an avatar
3. Confirm the QE did not recompose
4. Test for regression in the back button navigation - Go through the OAuth flow, Alt text page, etc.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.

	App Name	Gravatar Demo
	Commit	4cfb02e
	Direct Download	gravatar-demo-prototype-build-pr534-4cfb02e.apk

[hamorillo]

I've tested the PR, it works as expected.

When an avatar is selected the onAvatarSelected lambda is invoked and this triggered the recomposition caused by the changed startDestination.

Can you explain this a little bit more, please. I don't fully understand why that was happening.

[AdamGrzybkowski]

Can you explain this a little bit more, please. I don't fully understand why that was happening.

That's a good question. I only have a guess but no concrete answer. The startDestination is part of the Graph that is a param in a NavHost Composable. The onAvatarSelected is a lambda passed from the very top that goes through all the composables and must be invoking the recomposition due to a modified Graph state on its way up.

[hamorillo]

🚀