QuickEditor: Load Avatar object from AvatarsRepository in AltTextViewModel
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamorillo
added
[Feature] Gravatar-Quickeditor
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
hamorillo
commented
Jan 10, 2025
| @@ -4,4 +4,6 @@ internal sealed class AltTextAction { | |||
| data object AltTextUpdated : AltTextAction() | |||
|
|
|||
| data object AltTextUpdateFailed : AltTextAction() | |||
|
|
|||
| data object AvatarCantBeLoaded : AltTextAction() | |||
There was a problem hiding this comment.
This case shouldn't occur in the QE, but just in case and as a way to handle it.
gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/alttext/AltTextViewModel.kt
Outdated
Show resolved
Hide resolved
gravatar-quickeditor/src/test/java/com/gravatar/quickeditor/ui/alttext/AltTextViewModelTest.kt
Outdated
Show resolved
Hide resolved
hamorillo
force-pushed
the
hamorillo/523-alttextpage-required-params
branch
from
59d0f80 to
78dfd27
Compare
We can load the avatar data from the repository just by using the avatarId to remove the extra parameters we used to navigate to the AltTextPage.
hamorillo
force-pushed
the
hamorillo/523-alttextpage-required-params
branch
from
78dfd27 to
ef9fc5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #523
Description
With the recent implementation of the
AvatarStoragewe are ready to remove the extra params we needed to open the AltTextPage (url and alt_text).We can load the avatar data from the repository just by using the
avatarIdso we can simplify the navigation as we only need the email and the avatarId to open the AltTextPage.Testing Steps