QuickEditor: Clickable alt text help link brings to support page #528
Conversation
mlumeau
added
new feature
mlumeau
changed the title
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
| tint = MaterialTheme.colorScheme.primary, | ||
| contentDescription = stringResource(id = R.string.gravatar_qe_avatar_alt_text_section_what_is), | ||
| modifier = Modifier.clickable { | ||
| uriHandler.openUri(GRAVATAR_ALT_TEXT_HELP_URL) |
There was a problem hiding this comment.
⛏️ Nitpicking: We can try to increase the clickable area slightly (maybe with padding? But, indeed, we don't have a lot of space, so feel free to omit this comment.
There was a problem hiding this comment.
Added a 4dp padding to the button, that's all I could do without increasing the height of the page.
There was a problem hiding this comment.
With the new padding, the "?" button is not aligned with the Save button and looks weird. I didn't realize about that when I wrote my first comment. Maybe we should keep it as it was (without the padding) and not modify all paddings in the composables. Sorry for bothering you. 😞
There was a problem hiding this comment.
As you prefer 😅 I didn't notice the misalignment until your remark. I'll revert and merge!
This reverts commit 3185a2d.
Closes #500
Description
This PR adds a navigation to the support page article regarding alt text to the
"What is alt text?" label"?" button in the alt text dialog.Navigation happens in a new browser tab, to be consistent with the behavior of other links.
Testing Steps
"What is alt text?"the "?" button