Introduce Buildkite pipeline config #40
Conversation
wzieba
changed the title
Actually I think those reports are not useful. The static code analysis tools reports issues directly to the log and browsing them there is faster and more convient than downloading artifacts.
| - label: "Build" | ||
| command: | | ||
| echo "--- ⚒️ Building" | ||
| ./gradlew assemble |
There was a problem hiding this comment.
This changed from build to assemble because build task in Android Gradle Plugin also performs tests (which we do in a separate job)
There was a problem hiding this comment.
This changed from build to assemble because build task in Android Gradle Plugin also performs tests (which we do in a separate job)
Worth an inline # comment to keep that info for future readers of the file? 🤔
|
Thanks @hamorillo for the review! I'll also ask Apps Infra member to verify if it's all good. hi @AliSoftware ! Are you fine with reviewing this PR? 🙂 |
They're not needed at this moment
Details internally: https://wp.me/paaHJt-5Rr
Add a comment that helps to understand origin of variables
There was a problem hiding this comment.
Setup looks good to me now 👍
PS: Side note that you might want to create the .tf terraform setup for this pipeline soon-ish in buildkite-ci PR, because our doc about this in buildkite-ci mentions that the preferred way is usually to create the Buildkite project from the .tf (Option 1), and while importing an existing pipeline/project after the fact (Option 2) is not impossible, it might lead to trickier cases. So you might end up wanting to delete the pipeline/project in Buildkite, then recreate it via terraform, and then check again that the setup still works as expected with your pipeline.yml after that.
| - label: "Build" | ||
| command: | | ||
| echo "--- ⚒️ Building" | ||
| ./gradlew assemble |
There was a problem hiding this comment.
This changed from build to assemble because build task in Android Gradle Plugin also performs tests (which we do in a separate job)
Worth an inline # comment to keep that info for future readers of the file? 🤔
Description
This PR introduces Buildkite pipeline for the project that executes the same Gradle tasks as the GitHub Actions workflow: https://github.com/gravatar/Gravatar-SDK-Android/blob/trunk/.github/workflows/android.yml