Some fixes and additional options. #55
Open
+48
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
commented
Aug 10, 2016
Schamper
commented
- Fixes request interceptors/filters.
- Additional options for binding.
- Additional options for proxy creation.
AutomatedTester
approved these changes
Oct 27, 2016
|
Could you rebase this please and I will get it merged |
|
I would rebase this if I could. 👍 |
|
it'd be nice if this was merged 👍 |
|
Looks like I am going to have to manually try rebase this. The previous rebase doesnt appear to be clean and has other commits. WIll try get to it soon |
scythargon
reviewed
Feb 15, 2017
| data=js) | ||
| return r.status_code | ||
|
|
||
| def request_filter(self, js): |
There was a problem hiding this comment.
Hi! Could this method help me to prevent interception of all websocket connections according to this issue? lightbody/browsermob-proxy#408
If so - what should I write in js function?
Thanks in advance!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.