Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): catch storage callback exception #836

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(s3stream): catch storage callback exception #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions s3stream/src/main/java/com/automq/stream/s3/S3Storage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
import java.util.stream.Collectors;
import java.util.stream.IntStream;

import static com.automq.stream.utils.FutureUtil.suppress;


public class S3Storage implements Storage {
private static final Logger LOGGER = LoggerFactory.getLogger(S3Storage.class);
Expand Down Expand Up @@ -426,6 +428,10 @@ private void handleAppendRequest(WalWriteRequest request) {
}

private void handleAppendCallback(WalWriteRequest request) {
suppress(() -> handleAppendCallback0(request), LOGGER);
}

private void handleAppendCallback0(WalWriteRequest request) {
TimerUtil timer = new TimerUtil();
List<WalWriteRequest> waitingAckRequests;
Lock lock = getStreamCallbackLock(request.record.getStreamId());
Expand Down
Loading