perf: use Iterator rather than List in BlockBatch.futures (0.20%)

Signed-off-by: Ning Yu <[email protected]>
AutoMQ · Jan 12, 2024 · a058058 · a058058
1 parent e7eee29
commit a058058
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 12 deletions.
diff --git a/s3stream/src/main/java/com/automq/stream/s3/S3Stream.java b/s3stream/src/main/java/com/automq/stream/s3/S3Stream.java
@@ -56,7 +56,6 @@
 import java.util.concurrent.locks.ReentrantLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import java.util.function.Consumer;
-import java.util.stream.Collectors;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/s3stream/src/main/java/com/automq/stream/s3/wal/BlockBatch.java b/s3stream/src/main/java/com/automq/stream/s3/wal/BlockBatch.java
@@ -19,7 +19,7 @@
 
 import java.util.Collection;
 import java.util.Collections;
-import java.util.List;
+import java.util.Iterator;
 import java.util.concurrent.CompletableFuture;
 
 public class BlockBatch {
@@ -53,12 +53,30 @@ public Collection<Block> blocks() {
         return Collections.unmodifiableCollection(blocks);
     }
 
-    public List<CompletableFuture<WriteAheadLog.AppendResult.CallbackResult>> futures() {
-        return blocks.stream()
-            .map(Block::futures)
-            .flatMap(List::stream)
-            .toList();
+    public Iterator<CompletableFuture<WriteAheadLog.AppendResult.CallbackResult>> futures() {
+        return new Iterator<>() {
+            private final Iterator<Block> blockIterator = blocks.iterator();
+            private Iterator<CompletableFuture<WriteAheadLog.AppendResult.CallbackResult>> futureIterator = blockIterator.next().futures().iterator();
 
+            @Override
+            public boolean hasNext() {
+                if (futureIterator.hasNext()) {
+                    return true;
+                } else {
+                    if (blockIterator.hasNext()) {
+                        futureIterator = blockIterator.next().futures().iterator();
+                        return hasNext();
+                    } else {
+                        return false;
+                    }
+                }
+            }
+
+            @Override
+            public CompletableFuture<WriteAheadLog.AppendResult.CallbackResult> next() {
+                return futureIterator.next();
+            }
+        };
     }
 
     public void release() {

diff --git a/s3stream/src/main/java/com/automq/stream/utils/FutureUtil.java b/s3stream/src/main/java/com/automq/stream/utils/FutureUtil.java
@@ -17,7 +17,7 @@
 
 package com.automq.stream.utils;
 
-import java.util.Collection;
+import java.util.Iterator;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionException;
 import java.util.concurrent.ExecutionException;
@@ -93,14 +93,16 @@ public static Throwable cause(Throwable ex) {
         return ex;
     }
 
-    public static <T> void completeExceptionally(Collection<CompletableFuture<T>> futures, Throwable ex) {
-        for (CompletableFuture<T> future : futures) {
+    public static <T> void completeExceptionally(Iterator<CompletableFuture<T>> futures, Throwable ex) {
+        while (futures.hasNext()) {
+            CompletableFuture<T> future = futures.next();
             future.completeExceptionally(ex);
         }
     }
 
-    public static <T> void complete(Collection<CompletableFuture<T>> futures, T value) {
-        for (CompletableFuture<T> future : futures) {
+    public static <T> void complete(Iterator<CompletableFuture<T>> futures, T value) {
+        while (futures.hasNext()) {
+            CompletableFuture<T> future = futures.next();
             future.complete(value);
         }
     }