Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the tenant id parameter name from tenantId to tenant_id #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nnsay
Copy link
Contributor

@nnsay nnsay commented Jul 17, 2024

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update readme.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository, such as:
    • npm run prettier:check passes
    • npm run eslint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

@nnsay nnsay force-pushed the fix/tenantid-parameter-name branch from 7013f9e to ec37845 Compare July 17, 2024 04:06
@nnsay
Copy link
Contributor Author

nnsay commented Jul 17, 2024

So sorry, I find I make a mistake in last PR. In the real testing, the tenant id should be tenant_id but not tenantId

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# interactive rebase in progress; onto 1c1cca8
# Last command done (1 command done):
#    pick ec37845 fix: change the tenant id parameter name from tenantId to tenant_id
# No commands remaining.
# You are currently rebasing branch 'fix/tenantid-parameter-name' on '1c1cca8'.
#
# Changes to be committed:
#	modified:   src/AuthenticationClient.ts
#	modified:   src/AuthenticationClientInterface.ts
#
@nnsay nnsay force-pushed the fix/tenantid-parameter-name branch from ec37845 to 1f7a65c Compare September 18, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant