fix gemma4_assistant: arch name, tensor names, MTP dimension alignment - #72
Open
limitlessstoner wants to merge 2 commits into
Open
Conversation
- Change arch string 'gemma4-assistant' -> 'gemma4_assistant' to match GGUF - Change tensor names 'nextn.*' -> 'mtp.*' to match GGUF convention - Remove strict n_layer_nextn == n_layer_all assertion - Remove n_embd_out != n_embd assertion - Read n_embd_backbone dynamically from projection tensor shape - Fall back to n_layer when n_layer_nextn key is absent - Propagate n_embd_backbone into hparams for graph building - Set n_embd_out_impl to backbone size for MTP compatibility check - Allow partial tensor loading for GEMMA4_ASSISTANT
Accept --draft-block-size and --draft-max (alias to speculative draft n_max) and --spec-type mtp (alias to draft-mtp), so the server wrapper can drive this build with the same flags as the published Atomic Windows binaries. Assisted-by: Kilo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Additional information
Requirements