Epic/cognito/develop #215
Merged
Epic/cognito/develop #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use unique resource names for each environment to allow multiple environments to launch at a time Export the role name Remove circular reference to IAM policy
repo config is not used, it's available as a stack export
export the role ARN rather than name
update eksctl command to use existing role remove hard coded values and use config
add env vars
only send slack notifications for production
# Conflicts: # build.gradle # grails-app/controllers/au/org/ala/userdetails/RegistrationController.groovy # grails-app/services/au/org/ala/userdetails/AuthorisedSystemService.groovy # grails-app/services/au/org/ala/userdetails/UserService.groovy # grails-app/views/admin/index.gsp # userdetails-gorm/src/test/groovy/au/org/ala/userdetails/gorm/RegistrationControllerSpec.groovy # userdetails-plugin/grails-app/controllers/au/org/ala/userdetails/AdminController.groovy # userdetails-plugin/grails-app/controllers/au/org/ala/userdetails/RoleBasedInterceptor.groovy # userdetails-plugin/grails-app/controllers/au/org/ala/userdetails/UserController.groovy # userdetails-plugin/grails-app/services/au/org/ala/userdetails/PasswordService.groovy # userdetails-plugin/grails-app/views/user/_form.gsp # userdetails-plugin/grails-app/views/user/create.gsp
yasima-csiro
requested review from
brucehyslop
and removed request for
brucehyslop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.