#3432, AtlasOfLivingAutralia/ecodata#1047, AtlasOfLivingAutralia/ecod… #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata#1049 - electorate is excluded state is added to exclude list - selecting primary electorate override automatically enables primary state override
chrisala
requested changes
Feb 20, 2025
|
|
||
| statesOfNewOtherExcludedElectorates && statesOfNewOtherExcludedElectorates.forEach(function(state) { | ||
| if (availableStates.indexOf(state) > -1) { | ||
| self.geographicInfo.otherExcludedStates.push(state); |
There was a problem hiding this comment.
We should only exclude the State associated with the excluded Electorate if there are no other (non excluded) Electorates in that same State - otherwise we are excluding a valid state.
chrisala
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ata#1049