Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve accuracy of state and electorate facets #3431

Closed
wants to merge 3 commits into from
Closed

Conversation

temi
Copy link
Contributor

@temi temi commented Feb 5, 2025

added autoElectFacet and autoStateFacet to replace electFacet and stateFacet from project explorer

added autoElectFacet and autoStateFacet to replace electFacet and stateFacet from project explorer
@temi temi requested a review from chrisala February 5, 2025 00:40
temi added 2 commits February 5, 2025 13:33
fix broken test
- renamed autoStateFacet to projectStateFacet and autoElectFacet to projectElectFacet
- removed separate call to get geographic info
Copy link
Collaborator

@chrisala chrisala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once ecodata is merged please roll back the change to build.yml and then we'll merge this one.

@temi temi closed this Feb 6, 2025
@temi temi deleted the feature/issue3430 branch February 6, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants