Event core data #880
Merged
Event core data #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dr entry - enabled access to APIs with JWT token
- added expression evaluator to generate value of an attribute in a record - added test cases for checking event core archive and expression evaluation
- better multimedia data extraction
chrisala
requested changes
Feb 7, 2025
grails-app/controllers/au/org/ala/ecodata/HarvestController.groovy
Outdated
Show resolved
Hide resolved
| @@ -48,6 +48,7 @@ class ProjectActivity { | |||
| MapLayersConfiguration mapLayersConfig | |||
| String surveySiteOption | |||
| boolean canEditAdminSelectedSites | |||
| boolean published | |||
There was a problem hiding this comment.
Ideally we'd use the "publicationStatus" flag here for consistency with MERIT?
There was a problem hiding this comment.
Unfortunately, this flag was added long back in BioCollect but never added to domain object. Will add as a tech debt.
| context.metadata = metadata | ||
| data.context = context | ||
| def binding = new Binding(data) | ||
| GroovyShell shell = new GroovyShell(binding) |
There was a problem hiding this comment.
I'd be more comfortable if we could find a more limited expression evaluator here. Having a full GroovyShell evaluate expressions seems to be asking for a future security issue. Would SpEL be sufficient for this use case? (this would also facilitate a move to spring boot at some future point in time)
|
@chrisala CR comments have been addressed. |
chrisala
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisala PR has fix for recruitment protocol's individual count being sum of three columns. It also generates event core archive file.