Electorate and State facets should be consistent with project overview results

[temi]

• added new facets to support electorates and states from geographic info property and sites

[chrisala]

Maybe consider renaming "autoStateFacet/autoElectFacet" as "projectStateFacet"/"projectElectFacet" as it's not auto if the user overrides the geographic info?

Given we are now displaying this every time a project is opened and static caching it in the project explorer it might be worth just saving it on the Project entity rather than recalcuating it each call. (It's called quite a lot in the logs and often takes 100-300 milliseconds to return)

[temi]

@chrisala yes, "projectStateFacet"/"projectElectFacet" is a better name. I will rename them.

Saving this information will mean updating the project every time a new site is added/updated/deleted. Coding can get complex and could possibly have negative consequence on system performance. I will check for ways to make this faster. Let me know if there are alternatives.

[chrisala]

Saving this information will mean updating the project every time a new site is added/updated/deleted. Coding can get complex and could possibly have negative consequence on system performance. I will check for ways to make this faster. Let me know if there are alternatives.

My perspective at the moment is it's having a bigger impact on system performance as it is now.
e.g. today so far it's been called ~250 times with response times between 30 and 300 milliseconds
Once we add the indexing it will be called for every project / site write as well (as these trigger a project reindex)

By comparison we've had 13 site writes and 18 project writes. Project writes are responding on average in 10-30 milliseconds.

Maybe we could cache the read and invalidate it when a site is updated (and we do the re-intersect)?

[temi]

Yes, agree this needs to be faster. Do you have the project ids for which this takes a long time?

[temi]

@chrisala I have updated code as discussed.