Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#935 solr tagging and excluding filters #936

Merged
merged 8 commits into from
Jan 14, 2025
Merged

#935 solr tagging and excluding filters #936

merged 8 commits into from
Jan 14, 2025

Conversation

nickdos
Copy link
Contributor

@nickdos nickdos commented Jan 10, 2025

@nickdos nickdos linked an issue Jan 10, 2025 that may be closed by this pull request
Add optional search param to allow "SOLR tagging and Excluding Filters" #935
Open
@nickdos nickdos requested a review from adam-collins January 13, 2025 22:09
adam-collins
adam-collins approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@adam-collins adam-collins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Tests should be using the SOLR field names not the old names that get translated with the locally installed JSON config file. This appears to be a problem for existing tests as well as these new ones.

@nickdos
Copy link
Contributor Author

nickdos commented Jan 14, 2025 •
edited
Loading

Tests should be using the SOLR field names not the old names that get translated with the locally installed JSON config file. This appears to be a problem for existing tests as well as these new ones.

Good point - I'll add this to the issue to fix all the tests

@nickdos
#935 Made combined excluding optional
a0cc177 
Default to false but configurable in the future via config file.
@nickdos
#935 Bump version number to 3.6.0-SNAPSHOT
81dc1f0
@nickdos nickdos merged commit eb4e880 into develop Jan 14, 2025
1 check passed
@nickdos nickdos deleted the 935-solr-tagging-and-excluding-filters branch January 14, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-collins adam-collins adam-collins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional search param to allow "SOLR tagging and Excluding Filters"
2 participants
@nickdos @adam-collins